Skip to content

Conversation

SethTisue
Copy link
Member

No description provided.

@SethTisue
Copy link
Member Author

ah ffs, now MiMa is failing in the forward-compat direction

some of the errors are like:

[error]    * private class scala.collection.generic.GenericParCompanion#ToFactory is inaccessible in previous version, it must be public.
[error]      filter with: ProblemFilters.exclude[InaccessibleClassProblem]("scala.collection.generic.GenericParCompanion$ToFactory")

and then the rest of them are like:

[error]    * static method defaultForkJoinPool()java.util.concurrent.ForkJoinPool in interface scala.collection.parallel.ForkJoinTasks does not have a correspondent in previous version
[error]      filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.parallel.ForkJoinTasks.defaultForkJoinPool")

these look like probable Scala 3 bugfixes

although it's tempting to YOLO this...

...it would be safer to protect ourselves by going to 1.1.0. it's a bit annoying that Scala 2 users would also have to do the minor version bump even though it's only the Scala 3 version that changed, but oh well.

@SethTisue
Copy link
Member Author

I'll push a v1.1.0 tag instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant